Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: upgrade to Bazel 3.5.0, rules_rust latest (1/n) #4301

Closed
wants to merge 4 commits into from

Conversation

wchargin
Copy link
Contributor

@wchargin wchargin commented Nov 9, 2020

Summary:
Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new
linker API introduced as a breaking Bazel change:
bazelbuild/bazel#10860

This API requires Bazel 3.0.0, which is fine for us. We also need to
upgrade to 3.5.0 for incoming Node changes, so we do that now, too.

Because we can’t manage to build our whole test suite at once on CI
resources, this patch also disables all the builds. We’ll re-enable them
incrementally. See #4092, et al. for prior art.

Test Plan:
Locally, everything builds, all tests pass, and TensorBoard looks okay
enough.

wchargin-branch: bazel-3.5.0

Summary:
Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new
linker API introduced as a breaking Bazel change:
<bazelbuild/bazel#10860>

This API requires Bazel 3.0.0, which is fine for us. We also need to
upgrade to 3.5.0 for incoming Node changes, so we do that now, too.

Test Plan:
Everything builds, all tests pass, and TensorBoard looks okay enough.

wchargin-branch: bazel-3.5.0
wchargin-source: 8ace612
wchargin-branch: bazel-3.5.0
wchargin-source: a206e8a18d1cca5eb1ffb2f10b85ba5a94e98103
wchargin-branch: bazel-3.5.0
wchargin-source: f3add0dff7a6e6193d400a393e1159a4c6d76351
wchargin-branch: bazel-3.5.0
wchargin-source: f3add0dff7a6e6193d400a393e1159a4c6d76351
@wchargin wchargin changed the title workspace: upgrade to Bazel 3.5.0, rules_rust latest workspace: upgrade to Bazel 3.5.0, rules_rust latest (1/n) Nov 10, 2020
@wchargin
Copy link
Contributor Author

Closing in favor of #4319. Thanks, @stephanwlee!

@wchargin wchargin closed this Nov 13, 2020
@wchargin wchargin deleted the wchargin-bazel-3.5.0 branch November 13, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants